gh-89083: add support for UUID version 6 (RFC 9562) #120650
Open
+236
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
nineteendo
reviewed
Jun 19, 2024
picnixz
commented
Jun 21, 2024
picnixz
commented
Jun 22, 2024
dolfinus
reviewed
Jun 22, 2024
picnixz
changed the title
picnixz
changed the title
picnixz
changed the title
|
I am puzzled by the PR title change – can you explain? |
|
Oh yes, after we discussed the v7 implementation, I preferred splitting the PR into 3 with one PR for each version. The |
|
«Reference implementation» makes me think that this code is in support or a spec, and maybe not best-written or optimized for production. If this is not the case, just «implementation» or «support» like before has the right connotations 🙂 |
|
Sure, I can make the change if you want (I'll edit the other title as well) |
hugovk
reviewed
Nov 16, 2024
Co-authored-by: Hugo van Kemenade <[email protected]>
picnixz
commented
Nov 17, 2024
picnixz
commented
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of the discussion in #89083, I decided to remove the previous commits on version 7 and 8 and restrict this specific PR to version 6 only. The previous post can be found in the history of this message.
For version 7, please discuss it on #121119.
For version 8, please discuss it on #123224.
📚 Documentation preview 📚: https://cpython-previews--120650.org.readthedocs.build/