-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
really drop python <=3.7 support #1476
Conversation
Filetrer all cod over `pyupgrade --py38-plus`. Signed-off-by: Tomasz Kłoczko <[email protected]>
Signed-off-by: Tomasz Kłoczko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes are valid — e.g. unnecessary imports — but there's also many incorrect changes. Unfortunately it will probably be faster for me to redo the changes than to review and guide you over GitHub comments :-/ I gave up reviewing after a few files because the signal / noise ratio wasn't great.
@@ -25,7 +25,6 @@ | |||
copyright = f"2013-{datetime.date.today().year}, Aymeric Augustin and contributors" | |||
author = "Aymeric Augustin" | |||
|
|||
from websockets.version import tag as version, version as release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will break generating the docs.
@@ -7,6 +7,7 @@ | |||
import django | |||
import websockets | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid gratuitous formatting changes. Also, probably the autoformatter built into the project would revert it at the next commit.
from websockets.server import serve | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, gratuitous change that will make the docs look worse.
I think I'm going to redo individual changes — again, faster to redo than review — which will eventually lead to the result that you're aiming for. Thank you for the sugestion! That's a good opportunity to clean up. |
OK so just cannel this PR and do that your way. |
Union types were introduced in Python 3.10. See https://peps.python.org/pep-0604/. As a consequence, this change isn't compatible with Python 3.8.
|
Oops. Actually not a problem thanks to |
Need to check that the docs still generate properly. |
As of f45286b all the good changes from this PR are in the main branch. |
Filetrer all cod over
pyupgrade --py38-plus
.