-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to baipp #524
base: main
Are you sure you want to change the base?
migrate to baipp #524
Conversation
RonnyPfannschmidt
commented
Aug 17, 2024
- migrate to pyproject.toml tooling
- migrate to https://github.com/hynek/build-and-inspect-python-package/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a few suggestions.
pyproject.toml
Outdated
[project] | ||
name = "pluggy" | ||
license = {text = "MIT"} | ||
authors = [{name = "Holger Krekel", email = "[email protected]"}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While at it should we update this? Not sure to what exactly though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm up for being on the hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm up for being on the hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking more if it is appropriate to add pytest core team <[email protected]>
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pyproject.toml migration LGTM, I'm not qualified to review the rest. Maybe adding pyproject.fmt first in pre-commit would be great.
4816b4b
to
0723def
Compare
@RonnyPfannschmidt gentle ping here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Probably worth updating the title/description of the PR before merging. |
0723def
to
af435fe
Compare
af435fe
to
4152891
Compare