Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to nox for automated testing #212

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Mar 14, 2024

Fixes #208. Should I remove the GH Actions CI workflow? I think it would still be useful for pull request validation purposes. It could be limited to linting, though.

@chrysle chrysle force-pushed the automated-testing-nox branch from a6e3fef to 2361233 Compare March 14, 2024 19:36
@chrysle
Copy link
Contributor Author

chrysle commented Jun 1, 2024

@pfmoore can this be merged or should #210 be incorporated?

@pfmoore pfmoore merged commit a1f0005 into pypa:main Jun 1, 2024
15 checks passed
@pfmoore
Copy link
Member

pfmoore commented Jun 1, 2024

should #210 be incorporated?

I'm honestly not that bothered. These days, ruff seems to be best practice rather than flake8 anyway. And ruff fmt now works as a formatter instead of black.

Someone should decide what the purpose of linting and autoformatting config is in this repository, and make a decision based on that. But it won't be me, as I don't want to get sucked into the arguments over which tool to use.

@chrysle chrysle deleted the automated-testing-nox branch June 2, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tox version? And tox best practices?
2 participants