Remove deprecated distutils for python 3.12 compatability #11893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borntohonk
force-pushed
the
develop
branch
3 times, most recently
from
252a0c3 to
efb2783
Compare
|
(i apologize for messy PR, but I wanted I wanted to address tox after realizing the tests were failing due to test method being deprecated) |
|
My understanding is that https://github.com/pymedusa/Medusa/blob/master/.github/workflows/api-tests.yml |
|
after a lot of confusion on my end, it seems the api test is using dredd, which is made by apriary, which is owned by oracle since 8 years ago and deprecated last month |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in the medusa discord, distutils causes crashes for end users because of lines 6 and 45 in medusa/updater/update_manager.py
due to references to distutils, which is deprecated in python 3.12
I've also attempted to update helper libraries which are not needed to address the crash itself.