[ENH] variable arguments support in select

[samukweku]

PR Description

Please describe the changes proposed in the pull request:

• support variable arguments, similar to select_columns/select_rows
• ultimately make a single function for column/index selection
• deprecation notice for select_columns and select_rows

This PR improves the select function.

PR Checklist

Please ensure that you have done the following:

1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

2. If you're not on the contributors list, add yourself to AUTHORS.md.

3. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
   • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

• Building a preview of the docs on Netlify
• Automatically linting the code
• Making sure the code is documented
• Making sure that all tests are passed
• Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

• @ericmjl

[ericmjl]

🚀 Deployed on https://deploy-preview-1288--pyjanitor.netlify.app

[codecov]

Codecov Report

Merging #1288 (8756009) into dev (43a606a) will increase coverage by 0.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1288      +/-   ##
==========================================
+ Coverage   96.64%   97.38%   +0.74%     
==========================================
  Files          78       78              
  Lines        4172     4176       +4     
==========================================
+ Hits         4032     4067      +35     
+ Misses        140      109      -31     

[ericmjl]

Approving! Thank you for the excellent work as always, @samukweku!

[ericmjl]

Let's give it 1-2 more days to see if @thatlittleboy might have some bandwidth to review. (If not, no pressure, Jeremy!) We can merge otherwise.

[thatlittleboy]

Hiya, I'm leaving a comment for now (not a formal request for changes). I'm not fully sold on the internal API unfortunately, let me know what you think!

[samukweku]

Hiya, I'm leaving a comment for now (not a formal request for changes). I'm not fully sold on the internal API unfortunately, let me know what you think!

Good to have you around @thatlittleboy appreciate your PR reviews

[ericmjl]

@samukweku when you feel the PR is in a good state, let me know and I'll take a second look!

[samukweku]

@ericmjl yes it is ready for another review. Thanks

[ericmjl]

The pull request includes several changes across multiple files:

1. In AUTHORS.md, a new contributor, kianmeng, has been added.
2. In CHANGELOG.md, a new enhancement has been added under the 'Unreleased' section, stating that the select function now supports variable arguments.
3. In currency_column_to_numeric.py, the _clean_accounting_column function has been removed and its logic has been incorporated directly into the currency_column_to_numeric function.
4. In filter.py, the logic for converting the column_name to datetime has been simplified and the conditions for filtering dates have been updated.
5. In select.py, the select_columns and select_rows functions have been marked for deprecation in a future release and users are advised to use the jn.select function instead. The select function has been updated to support variable arguments and the ability to invert selection.
6. In utils.py, the _select function has been updated to handle the new arguments and inversion functionality introduced in the select function.
7. In test_filter_date.py, the tests have been updated to reflect the changes in the filter.py file.
8. In test_pivot_wider.py, comments have been added to indicate that the pivot_wider function will be deprecated in a future release and users are advised to use pd.pivot instead.
9. In test_select.py, new tests have been added to check the new functionality in the select function.
10. In test_sort_timestamps_monotonically.py, the test has been updated to use pd.concat instead of df.append.
11. The file test_clean_accounting_column.py has been deleted as the _clean_accounting_column function it was testing has been removed.

[ericmjl]

Okie dokes, re-approved!

[thatlittleboy]

I'll pre-approve, just a couple of minor revision points. Thanks Sam!

[ericmjl]

GitBot Summary of Changes

The pull request includes several changes across multiple files:

1. AUTHORS.md: Added a new contributor, kianmeng, to the list.
2. CHANGELOG.md: Updated the changelog to reflect the enhancement of the select function to support variable arguments.
3. currency_column_to_numeric.py: Refactored the currency_column_to_numeric function to improve efficiency and readability. Removed the _clean_accounting_column function and integrated its functionality directly into the main function.
4. filter.py: Simplified the date filtering logic and improved readability.
5. select.py: Deprecated the select_columns and select_rows functions and advised users to use the select function instead. Also, added the ability to invert selection of index/columns and provided the option to specify the axis for selection.
6. utils.py: Refactored the _select function to improve readability and efficiency.
7. test_filter_date.py: Updated tests to reflect changes in the date filtering logic.
8. test_pivot_wider.py: Updated tests to reflect changes in the pivot_wider function.
9. test_select.py: Added new tests for the updated select function.
10. test_sort_timestamps_monotonically.py: Updated tests to reflect changes in the sort_timestamps_monotonically function.
11. Removed test_clean_accounting_column.py as the _clean_accounting_column function was removed.

cc: @samukweku, please check for correctness!

[ericmjl]

Merged!