pyinfra/connectors: Fix overwriting of users known_hosts file (#1209) #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1208) A small fix that allows the example in issue pyinfra-dev#1207 to work.
Instead of relying on paramiko to correctly parse the full hostfile, this fix makes it so that we only append new keys to the hostfile rather than overwriting it completely. The old behaviour results in unwanted alterations to the hostfile, such as hostfile entries not parseable by paramiko disappearing without users consent, and comments being removed. I also split out the logic for appending hostkeys into a new function instead of having the code be unnecessarily repeated in multiple places. This makes the MissingHostKeyPolicy children a bit more readable IMO.
|
Forgot to do linting and squashing commits, will redo this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1209, making it so that we append new keys to the users known_hosts file instead of overwriting it.
I also added a testcase that should discover this breaking in the future.
Additionally:
Previous behaviour when adding a new key:
New behaviour: