Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force numpy<2.0 #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

force numpy<2.0 #70

wants to merge 2 commits into from

Conversation

ahms5
Copy link
Member

@ahms5 ahms5 commented Jun 28, 2024

see #69, no idea how to fix, It can be reproduces locally but its very odd.
since we will release a new version later, we can maybe stick to numpy<2.0 here.
feel free to check for alternatives

add matplotlib deprecation cm.viridis to cmap=plt.get_cmap('viridis')

@ahms5 ahms5 requested review from mberz and f-brinkmann June 28, 2024 07:54
@mberz mberz mentioned this pull request Jul 12, 2024
1 task
@mberz
Copy link
Member

mberz commented Jul 12, 2024

This is not the issue.
The issue is that aspect ratio handling doe not work properly within Matplotlib in python 3.8 in combination with numpy 2.x

Specifically, this fails:

ax.set_box_aspect([1, 1, 0])

which for some reason works on all other python versions we're testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants