Fixes class disambiguation logic when there is nested inheritance #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the case mentioned here in #117
Below is the example pointed out by @slafs
At the end class visits we are left with
CLS_CONTEXT_KEY
beingInstead of just disambiguating at one level over here
bump-pydantic/bump_pydantic/codemods/class_def_visitor.py
Lines 61 to 85 in dda0b55
I have changed the logic to recursively disambiguate its children as well.
I noticed that
ClassDefVisitor
unittest is fully commented out so I added an integration test for it. Happy to add the unittest if required.