Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid installing h5py from cache #430

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Avoid installing h5py from cache #430

wants to merge 3 commits into from

Conversation

kvrigor
Copy link
Member

@kvrigor kvrigor commented Sep 10, 2024 •
edited
Loading

From @yguclu:

If people have a cached version of the h5py library which was compiled using NumPy < 2.0 and try to install Psydac in a clean Python environment, they end up with a broken version. This is because the cached version of h5py tries to call C functions from NumPy 2.0 which are not ABI compatible.

Adding --no-cache-dir to pip guarantees that h5py is always built during installation. Re-using a prebuilt h5py (i.e. cached h5py) could become an issue stale when h5py dependencies upgrade.

@kvrigor kvrigor requested a review from yguclu September 10, 2024 09:44
@kvrigor kvrigor marked this pull request as draft September 10, 2024 09:44
@kvrigor kvrigor marked this pull request as ready for review September 10, 2024 09:57
@yguclu yguclu marked this pull request as draft September 25, 2024 07:30
@yguclu yguclu added the urgent PR should be merged ASAP label Nov 13, 2024
@kvrigor kvrigor marked this pull request as ready for review November 13, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu Awaiting requested review from yguclu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
urgent PR should be merged ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvrigor @yguclu