Cleanup warnings and failures in tests. #62
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two warnings.
Warning #1:
Warning #2:
This fixes both warnings in the obvious ways.
There was one failure when I ran the test suite locally:
Investigation shows that something changed between Python 3.11 and 3.12 in this area:
We're still using 3.11.9 locally and this was annoying me so I added a check to make it work in both scenarios. If there's a better way, I'm happy to do something else.