Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1580 Read symlinks for mysql commands that are deprecated in MariaDB 11 #1650

Closed
wants to merge 2 commits into from

Conversation

ajdelgado
Copy link

Summary

Provide a detailed description of all the changes present in this pull request.
MariaDB 11 is deprecating compatibility with MySQL commands. The deprecation message get in between the output while running this commands breaking providers. See more details in Issue #1580
As one of my first attempts to Ruby (sorry if the code is not up to standards), I added some test to check if the commands are actually symlinks and in that case read them and use the target.

Probably the code shouldn't take the stderr merge with stdout, and that would solve the issue. Also a version check could help indicate the specific command to run. But I thought that it was cleaner and covering future possible cases by just reading the symlink and running the target command.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.
#1580

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Antonio J. Delgado seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ajdelgado ajdelgado closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants