-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defaults memory_limit to undef instead of ignored 0b value #928
base: main
Are you sure you want to change the base?
Defaults memory_limit to undef instead of ignored 0b value #928
Conversation
As force pushes appeared to not update the old PR at #927 correctly - I've made a new PR. I've ran the unit tests via the PDK successfully on my local machine with this version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template only output the parameter when it has a value, so this look safe. LGTM!
Hi @ALTinners, can you please rebase your PR with main branch? |
From your working directory (in your feature branch, and assuming 'origin' is the name of the puppetlabs remote):
The PR will be updated automagically. |
…fault-undef-memory-limit
|
…fault-undef-memory-limit
Summary
From #748 - sets the default
memory_limits
value toundef
instead of0b
. As the Docker documentation states that0b
is an impossible value to use - it appears to be ignoring the0b
value. In which case this should not be a breaking change to any setup.Additional Context
Add any additional context about the problem here.
podman
usage as per the linked issueRelated Issues (if any)
#748
Checklist
puppet apply
)