Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install option escaping #362

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

notCalle
Copy link

Summary

Provide a detailed description of all the changes present in this pull request.

Adds two utility functions to perform the escaping, and argument splitting for install_options, as described in README#Install options with spaces.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Performing argument escape processing manually becomes very messy, and error prone, especially when the exact contents of arguments are composed from parameters.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

This performs the escaping, and splitting, of `install_options`, as
documented in the README.
@notCalle notCalle requested a review from a team as a code owner September 26, 2024 17:55
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants