Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnableSendfile per directory #2535

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

kajinamit
Copy link
Contributor

@kajinamit kajinamit commented Mar 17, 2024

Summary

Support configuring the EnableSendfile option under Directory directives

Additional Context

The EnableSendfile option can be configured in a Directory directive to disable/enable the snedfile feature for specific paths as is described in https://httpd.apache.org/docs/2.4/en/mod/core.html#enablesendfile .

Related Issues (if any)

N/A

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, just using the actual configuration setting name for the key might make it easier to use it (we trend to do this in the rest of the module, with some exceptions unfortunately).

templates/vhost/_directories.erb Outdated Show resolved Hide resolved
The EnableSendfile option can be configured in a Directory directive
to disable/enable the snedfile feature for specific paths.
@kajinamit kajinamit force-pushed the vhost-dirs-sendfile branch from 5d1fad5 to 09d5499 Compare March 17, 2024 15:53
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. LGTM!

@ekohl ekohl merged commit 19eb28a into puppetlabs:main Apr 29, 2024
42 checks passed
@kajinamit kajinamit deleted the vhost-dirs-sendfile branch April 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants