Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DOC) Correct the known issue fix for the inbuilt templates #1424

Merged
merged 1 commit into from
Dec 5, 2024
Merged

(DOC) Correct the known issue fix for the inbuilt templates #1424

merged 1 commit into from
Dec 5, 2024

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Dec 5, 2024 •
edited
Loading

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan added maintenance Internal maintenance work that shouldn't appear in the changelog documentation labels Dec 5, 2024
@david22swan david22swan requested a review from a team as a code owner December 5, 2024 16:04
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (8a1baec) to head (5294a2e).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1424   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files         127      127           
  Lines        5317     5317           
=======================================
  Hits         4705     4705           
  Misses        612      612

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LukasAud
LukasAud approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit ed8714c into main Dec 5, 2024
11 of 12 checks passed
@LukasAud LukasAud deleted the known_issues_correction branch December 5, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

Assignees
No one assigned
Labels
documentation maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david22swan @LukasAud