This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Launch configuration/associate public ip #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunner
suggested changes
Jan 12, 2017
| @@ -614,6 +614,9 @@ Specifies that basic state of the resource. Valid values are 'attached', 'detach | |||
| #####`vpc` | |||
| *Optional* A hint to specify the VPC. This is useful when detecting ambiguously named security groups that might exist in different VPCs, such as 'default'. This parameter is set at creation only; it is not affected by updates. | |||
|
|
|||
| #####`associate_public_ip_address` | |||
| *Optional* One or more mappings that specify how block devices are exposed to the instance. For more information, see [Block Device Mapping](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/block-device-mapping-concepts.html) in the Amazon Elastic Compute Cloud User Guide. This parameter is set at creation only; it is not affected by updates. | |||
There was a problem hiding this comment.
The docs describe block devices; is that copy/paste?
| @@ -36,6 +36,7 @@ def self.prefetch(resources) | |||
| def self.config_to_hash(region, config) | |||
| # It appears possible to get launch configurations manually to a state where | |||
| # they return the identifier of an invalid or a non-existent security groups | |||
| # puts "config_to_hash(#{config})" | |||
| @@ -77,3 +92,9 @@ def insync?(is) | |||
| end | |||
|
|
|||
| end | |||
| def read_only_warning(value, property, should) | |||
There was a problem hiding this comment.
The module already has the ability for marking properties read-only; why this addition?
|
@benpillet Would you mind coming back to address the comments here please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property for the associate_public_ip_address option for a launch configuration