id security groups primarily by name (falling back to vpc_name / group_name) and much more

[mks-m]

this is proof of concept, it is also a mix of 2 large changes (sorry)

1. ec2_securitygroup name param value is written into both group_name and tags['Name'] and is used to uniquely identify the group
2. more complete implementation of ingress rules

cc @garethr

[garethr]

Hi @keymone, thanks for looking a this. It's probably worth pairing this back to one thing at a time I'm afraid.

It's also worth tracking #55, which contains support for much more complex security group rules (see the acceptance tests and unit tests for examples of those), it supports the suggestions in #42 and more.

[garethr]

@keymone The code in #124 supports setting rules on default security groups in VPC using a composite namevar. Let me know if that works for you if you have a moment.

[garethr]

Given the overlap with #55, and the work in #124 and the lack of movement on this I'm moved to close the PR. Apologies for not finding more time to push this particular feature forward.