Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define Notification model #876

Merged
merged 4 commits into from
Dec 15, 2024
Merged

Conversation

laminne
Copy link
Member

@laminne laminne commented Dec 10, 2024

close #874

What does this PR do?

  • Notificationモデルの定義
    • Announceモデルはv0.1では取り敢えずやらないことにします

Additional information

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 73.13433% with 18 lines in your changes missing coverage. Please review.

Project coverage is 49.71%. Comparing base (26dd98c) to head (cec7405).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/notification/model/notification.ts 65.38% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   49.47%   49.71%   +0.24%     
==========================================
  Files         177      179       +2     
  Lines       15981    16141     +160     
  Branches     1251     1268      +17     
==========================================
+ Hits         7906     8025     +119     
- Misses       8075     8116      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/notification/model/notification.ts Outdated Show resolved Hide resolved
pkg/notification/model/notification.ts Outdated Show resolved Hide resolved
@laminne laminne requested a review from MikuroXina December 11, 2024 14:51
@laminne laminne enabled auto-merge (squash) December 12, 2024 02:53
@laminne laminne requested a review from MikuroXina December 15, 2024 10:33
@laminne laminne merged commit 4b2c23f into main Dec 15, 2024
5 checks passed
@laminne laminne deleted the feat/874-notification-model-definition branch December 15, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: Notificationモデルの定義をする
2 participants