Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added cache retention limit to list/home timeline #806

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Nov 1, 2024

close #801

What does this PR do?

  • リスト/ホームタイムラインのキャッシュを300件までに制限するように
  • ノートのソートに使う要素をCreatedAtからIDに
  • テスト用repositoryでリストのキャッシュを正常に行えるように

Additional information

@laminne laminne added the T: improvement Improvement of functions, etc. label Nov 1, 2024
@laminne laminne self-assigned this Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 77.51196% with 47 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@3a834a7). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/timeline/adaptor/repository/valkeyCache.ts 6.25% 30 Missing ⚠️
pkg/timeline/service/push.ts 81.03% 11 Missing ⚠️
pkg/timeline/adaptor/repository/dummyCache.ts 89.83% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage        ?   49.40%           
=======================================
  Files           ?      149           
  Lines           ?    13771           
  Branches        ?     1077           
=======================================
  Hits            ?     6803           
  Misses          ?     6968           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laminne laminne enabled auto-merge (squash) November 1, 2024 02:07
pkg/timeline/adaptor/repository/dummyCache.ts Outdated Show resolved Hide resolved
pkg/timeline/service/push.ts Outdated Show resolved Hide resolved
pkg/timeline/service/push.ts Outdated Show resolved Hide resolved
pkg/timeline/service/push.ts Outdated Show resolved Hide resolved
@laminne
Copy link
Member Author

laminne commented Nov 1, 2024

タイムラインへのノート配信は1つづつ行うので複数一気に追加することを想定することはしていません

pkg/id/mod.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit 4cad0d6 into main Nov 2, 2024
3 checks passed
@laminne laminne deleted the feat/801-timeline-cache-limit branch November 2, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: improvement Improvement of functions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: リスト/ホームタイムラインにキャッシュ保持制限を設けるようにする
2 participants