Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to UV universal viewer v4 #5778

Open
hackartisan opened this issue Apr 28, 2023 · 6 comments · May be fixed by #5810
Open

Update to UV universal viewer v4 #5778

hackartisan opened this issue Apr 28, 2023 · 6 comments · May be fixed by #5810

Comments

@hackartisan
Copy link
Member

hackartisan commented Apr 28, 2023

blocks #5376

this is the closest thing there is to an upgrade guide: https://github.com/UniversalViewer/universalviewer/wiki/UV-Examples

As part of this upgrade we can import and use uv directly instead of polling for its load like we did here https://github.com/pulibrary/figgy/pull/5774/files#diff-b098a3077a1b985669f90a65c37d07c6721005767eaf48a32c11b2443c0ac99aR4

@hackartisan
Copy link
Member Author

New example developed during UV community call: https://codesandbox.io/s/uv-vite-example-9ie3rh

@hackartisan hackartisan changed the title Update to universalviewer v4 Update to UV universal viewer v4 May 15, 2023
@hackartisan hackartisan self-assigned this May 15, 2023
@hackartisan
Copy link
Member Author

hackartisan commented May 15, 2023

Things to test:

  • CDL Timer (should work unless divs have changed)
  • buttons at bottom
  • if you have a playlist of a bunch of things and you listened through, it would break. It would either stop or it would pick up in the middle of a song. You have to actually listen to the playlist, you can't skip around. The patch may be gone from a previous update.
  • We changed it so the duration of the track is just the duration of the track, rather than the whole manifest. Check a recording with multiple tracks.

related issues:

@tpendragon
Copy link
Contributor

tpendragon commented Oct 9, 2023

Blocked by a release of iiif-av-component and UV including it.

@tpendragon
Copy link
Contributor

Another thing to check: https://figgy.princeton.edu/catalog/56916dd5-8613-4f22-b82a-2e984b257e65

The table of contents for this record should expand on click and let you select the root section. The current example in UV doesn't but it might be a config thing.

@tpendragon
Copy link
Contributor

This is blocked because we've decided to set this aside until we're done with video.

@sdellis
Copy link
Member

sdellis commented Apr 17, 2024

This ticket was previously blocked because we thought we needed to upgrade UV to play video. We decided to use Clover instead of UV for video.

However, this ticket is still blocked because we have decided that Clover should be used for BOTH Video AND Audio, so we need to make sure that Audio uses Clover as the default viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants