Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility errors with Universal Viewer #5376

Open
sandbergja opened this issue Aug 19, 2022 · 4 comments
Open

Accessibility errors with Universal Viewer #5376

sandbergja opened this issue Aug 19, 2022 · 4 comments
Labels
blocked maintenance / research

Comments

@sandbergja
Copy link
Member

@sandbergja commented on Wed Aug 17 2022

Copying this over from @axamei's comment.

I've confirmed that these violations are still happening as of August 2022. I'm not sure if this issue should be in this repo or in Figgy -- and it probably should be broken into multiple tickets once we decide which repo it belongs in.

Critial violations:

  • Form elements must have labels (critical violation)
    • #view > iframe:nth-child(1) .image-selectionbox
    • iframe:nth-child(2) .image-selectionbox
    • #iframe_1 .image-selectionbox
  • Zooming and scaling must not be disabled (critial violation)
    • #view > iframe:nth-child(1) meta
    • iframe:nth-child(2) meta
    • #iframe_1 meta

Serious violations:

  • <html> element must have a lang attribute
    • #view > iframe:nth-child(1) html
    • iframe:nth-child(2) html
    • #iframe_1 html
  • Links must have discernible text
    • #view > iframe:nth-child(1) #top
    • iframe:nth-child(2) #top
    • #iframe_1 #top
@sandbergja sandbergja mentioned this issue Aug 19, 2022
Closed
@tpendragon
Copy link
Contributor

Marking this high priority just so we'll talk about it during our maintenance planning.

@tpendragon
Copy link
Contributor

We're delaying this discussion until next maintenance cycle - not enough of us were around.

@sdellis
Copy link
Member

sdellis commented Sep 23, 2022

Next step is to update to the latest version of UV first. If the issues persist, submit PRs to the most recent UV branch.

@hackartisan hackartisan mentioned this issue Apr 14, 2023
Closed
@hackartisan hackartisan mentioned this issue Apr 28, 2023
Open
@hackartisan
Copy link
Member

blocked by #5778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked maintenance / research
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sdellis @hackartisan @tpendragon @sandbergja