Creating 'wings service-install' command #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so I need to install wings to install wings? makes sense. |
|
no, you install wings and enable the wing as a service, automatically, you dont need to create wings.service, the code create it for you |
|
oh that actually makes sense, wouldn't it be better to call it |
parkervcp
requested changes
Sep 5, 2022
cmd/service_install.go
Outdated
| return | ||
| } | ||
|
|
||
| command := exec.Command("systemctl", "enable", "--now", serviceFile) |
There was a problem hiding this comment.
You are missing a systemctl daemon-reload after adding the systemd files. You need to reload after creating the file before you can start the service
There was a problem hiding this comment.
Yes i did really forget that, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command to create wings service automatically facilitating the installation process.