Use async contextmanager for timeouts #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run
test_serial.py
I got following error.This is because
async_timeout
dropped support for the sync context manager in version 5.0.0 (which was deprecated in 4.0.0). Becauserequirements.txt
saysasync_timeout>=3.0.0
I ended up with version 5.0.1 installed.To solve this I changed the calls to use the async contextmanager. The async context manager is also supported on version 3.0.0 of
async_timeout
so works without needing to change any dependecy versions.I tested with
test_serial.py
and that works fine. I did not test the others.On a sidenote, the
async_timeout
package as a whole has been deprecated in favor of usingasyncio.timeout
built into Python 3.11 or higher. If you don't mind bumping the minimum required Python version to 3.11 I can also update this PR to remove the need forasync_timeout
all together.