Try to update usrsctp instead since cflags do not realyl work

psi-im · Apr 12, 2024 · 9eae9d5 · 9eae9d5
1 parent 667ac9d
commit 9eae9d5
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/cmake/modules/IrisSCTP.cmake b/cmake/modules/IrisSCTP.cmake
@@ -37,12 +37,13 @@ else()
         -DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH} -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
         -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE} -DCMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM}
         -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER})
-    if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-        list(APPEND USRSCTP_BUILD_OPTIONS "-DCMAKE_C_FLAGS=-Wno-maybe-uninitialized")
-    endif()
-    if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-        list(APPEND USRSCTP_BUILD_OPTIONS "-DCMAKE_C_FLAGS=-Wno-uninitialized -Wno-unused-but-set-variable")
-    endif()
+    # Setting these options seems to have no any effect because those prepended and not appended
+    # if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+    #     list(APPEND USRSCTP_BUILD_OPTIONS "-DCMAKE_C_FLAGS=-Wno-maybe-uninitialized")
+    # endif()
+    # if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+    #     list(APPEND USRSCTP_BUILD_OPTIONS "-DCMAKE_C_FLAGS=-Wno-uninitialized -Wno-unused-but-set-variable")
+    # endif()
     if (EXISTS ${USRSCTP_SOURCE_DIR})
         message(STATUS "USRSCTP: found bundled sources")
         ExternalProject_Add(UsrSCTPProject
@@ -63,7 +64,7 @@ else()
             PREFIX ${USRSCTP_PREFIX}
             BINARY_DIR ${USRSCTP_BUILD_DIR}
             GIT_REPOSITORY ${IrisSCTPGitRepo}
-            GIT_TAG a17109528c75d01f6372d5c30851a639684c6e99
+            GIT_TAG 848eca82f92273af9a79687a90343a2ebcf3481d
             CMAKE_ARGS ${USRSCTP_BUILD_OPTIONS}
             BUILD_BYPRODUCTS ${USRSCTP_LIBRARY}
             INSTALL_COMMAND ""