Clean up the implementation of InternalSwap in MapField:
#19751
+9
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
- Rename `UnsafeShallowSwap`. The operation is called `InternalSwap` in all other types. - Remove the dynamic dispatch. It is no longer needed. - Make `InternalSwap` do the whole swap, including the map and the reflection payload. - Rename `MapFieldBase::SwapImpl` to `SwapPayload` to make it clearer on what it does and to prevent using it directly in the vtable. PiperOrigin-RevId: 708031253
copybara-service
bot
force-pushed
the
test_708031253
branch
from
7013de6 to
5c6b5bd
Compare
copybara-service
bot
changed the title
InternalSwap in MapField:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the implementation of
InternalSwapinMapField:UnsafeShallowSwap. The operation is calledInternalSwapin all other types.InternalSwapdo the whole swap, including the map and the reflection payload.MapFieldBase::SwapImpltoSwapPayloadto make it clearer on what it does and to prevent using it directly in the vtable.