Create logical definition #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is necessary because the spotify docker plugin does not work on Apple Silicon and the plugin itself is no longer maintained.
Replace spotify docker plugin with maven-exec plugin
… and removed "form" from the names
Docker push changes
Docker push changes
Factor out tabs from forms
Co-authored-by: Gheorghe Soimu <[email protected]>
…tegeproject/webprotege-gwt-ui into upload-postcoordination-file
…to upload-postcoordination-file
…e axis (#74) Co-authored-by: Gheorghe Soimu <[email protected]>
Co-authored-by: Gheorghe Soimu <[email protected]>
…tegeproject/webprotege-gwt-ui into upload-postcoordination-file
…e + changes from master (#76)
…tegeproject/webprotege-gwt-ui into upload-postcoordination-file
…-gwt-ui into upload-postcoordination-file � Conflicts: � pom.xml � webprotege-gwt-ui-client/pom.xml � webprotege-gwt-ui-client/src/main/java/edu/stanford/bmir/protege/web/client/inject/ClientProjectModule.java � webprotege-gwt-ui-server-core/pom.xml � webprotege-gwt-ui-server/pom.xml � webprotege-gwt-ui-shared-core/pom.xml � webprotege-gwt-ui-shared/pom.xml
…to create-logical-definition # Conflicts: # webprotege-gwt-ui-client/src/main/java/edu/stanford/bmir/protege/web/client/inject/ClientApplicationModule.java
# Conflicts: # webprotege-gwt-ui-client/src/main/java/edu/stanford/bmir/protege/web/client/inject/ClientProjectModule.java # webprotege-gwt-ui-shared/src/main/java/edu/stanford/bmir/protege/web/shared/postcoordination/PostCoordinationSpecification.java # webprotege-gwt-ui-shared/src/main/java/edu/stanford/bmir/protege/web/shared/postcoordination/WhoficEntityPostCoordinationSpecification.java
soimugeoWB
approved these changes
Oct 16, 2024
| this::initializeTable)); | ||
|
|
||
| @Inject | ||
| public LogicalDefinitionPortletViewImpl(DispatchServiceManager dispatchServiceManager) { |
There was a problem hiding this comment.
[sugestion]: from what i've seen from other view components in the application most of the actions that are made in a view should be handled by functional interfaces and the actual action should be defined in the presenter.
Normally i don't think you want to make dispatch calls and other major actions directly from the view. The view should be more or less just for showing the model, the presenter should do operations on the model and dictate what the view presents.
I think it's going to be a headache to change any of this now, but we should keep it in mind if we need to implement anything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.