Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer ignore "Pronamic" payment method when updating MemberPress subscription gateway #23

Conversation

rvdsteege
Copy link
Member

Fix #22.

ℹ️ The break causes an exactly matching payment method to have priority over the Pronamic payment method:

			if ( $gateway_method === $payment_method ) {
				break;
			}

Copy link
Member

@remcotolsma remcotolsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #22 (comment) for my feedback/concerns.

@remcotolsma
Copy link
Member

I will close this PR, we have worked out a new approach, see following comment for details:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

MemberPress subscription gateway not updating to "Pronamic" payment method
2 participants