Switch latestTag() to discard all tags except for full SemVer tags

We use the regex `^v\d+\.\d+\.\d+$` to only keep fully qualified SemVer tags when finding the newest tag. This ensures that the action also works on repos which have major-version tags.
projectsyn · Nov 6, 2023 · 5a2ef51 · 5a2ef51
1 parent 9cfb6b3
commit 5a2ef51
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/__tests__/version.test.ts b/__tests__/version.test.ts
@@ -56,7 +56,8 @@ describe('latestTag', () => {
       'v1.0.0',
       'v1.2.2',
       'foo-v1.0.0',
-      'bar'
+      'bar',
+      'v1'
     )
     getOctokitMock.mockImplementation(clientMock.mockFn)
 

diff --git a/src/version.ts b/src/version.ts
@@ -13,7 +13,7 @@ export async function latestTag(): Promise<string> {
   const tags = tagsResp
     .map(({ name }) => name)
     .filter(tag => {
-      return tag.startsWith('v')
+      return /^v\d+\.\d+\.\d+$/.test(tag)
     })
     .sort(rcompare)