Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate config map additional-root-apps #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simu
Copy link
Member

@simu simu commented Dec 18, 2024

This PR extends the component to generate the config map additional-root-apps which Steward reads to determine what additional ArgoCD AppProject and Application resources to bootstrap.

The config map must always be present, but the value of field teams can be an empty JSON list.

The list of teams in the config map should never contain the team owning the cluster, since that team keeps the "default" root app named root and the default app project named syn.

Additionally, we don't want to generate a root app and app project for teams which are listed in the parameter but which don't have any component instances assigned.

The full feature requires a version of Steward which includes projectsyn/steward#158

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@simu simu added enhancement New feature or request bump:minor labels Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

🚀 Merging this PR will release v4.1.0

Merging will trigger workflows Release

🛠️ Auto tagging enabled with label bump:minor

@simu simu changed the title Feat/additional root apps Generate config map additional-root-apps Dec 18, 2024
@simu simu force-pushed the feat/additional-root-apps branch 2 times, most recently from cbe6748 to c361f3d Compare December 19, 2024 16:45
simu added 2 commits December 20, 2024 17:09
We use `syn-teams.libsonnet` to get the list of non-owner teams for
which we need to generate additional root apps in Steward.

Please note that this implementation will only create root apps for
teams who are assigned to at least one application that's present in
the cluster.
The list of teams in the config map should never contain the team owning
the cluster, since that team keeps the "default" root app named `root`
and the default app project named `syn`.

Additionally, we don't want to generate a root app and app project for
teams which are listed in the parameter but which don't have any
component instances assigned.

The test case is setup to have a structure in parameter `syn` which
covers the cases outlined above.

Rendered from template version: main (ff9d5a8)
@simu simu force-pushed the feat/additional-root-apps branch from c361f3d to 077af4f Compare December 20, 2024 16:09
@simu simu requested a review from a team December 24, 2024 09:04
@simu simu marked this pull request as ready for review December 24, 2024 09:04
@simu
Copy link
Member Author

simu commented Dec 24, 2024

See projectsyn/documentation#182 for documentation

@simu simu force-pushed the feat/additional-root-apps branch from 077af4f to 3022570 Compare December 24, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:minor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant