Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run time permissions for CarDialer application #2687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devath1x
Copy link

@devath1x devath1x commented Oct 25, 2024

Grant the runtime permissions of CarDialerApp by default to display dialer context in dialer app with Bluetooth connected: android.permission.READ_CALL_LOG
android.permission.WRITE_CALL_LOG
android.permission.READ_PHONE_STATE
android.permission.CALL_PHONE
android.permission.SEND_SMS

Tests done: PBAP contact sync
1.Enable Bluetooth and connect to mobile.
2.open dialer application
3.Check for the contacts are able to sync.

Tracked-On: OAM-126720

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

Grant the runtime permissions of CarDialerApp by default to display
dialer context in dialer app with Bluetooth connected:
android.permission.READ_CALL_LOG
android.permission.WRITE_CALL_LOG
android.permission.READ_PHONE_STATE
android.permission.CALL_PHONE
android.permission.SEND_SMS

Tests done: PBAP contact sync
1.Enable Bluetooth and connect to mobile.
2.open dialer application
3.Check for the contacts are able to sync.

Tracked-On: OAM-126720
Signed-off-by: devath1x <[email protected]>
Signed-off-by: Cui, Yuxin <[email protected]>
Copy link
Contributor

@gowthambabu92 gowthambabu92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Nov 5, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

2 similar comments
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Nov 5, 2024
@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

Copy link
Contributor

@balajim001 balajim001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants