Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverity: fix the RESOURCE_LEAK in peeknpoke #9

Merged
merged 1 commit into from
Oct 9, 2024
Merged

coverity: fix the RESOURCE_LEAK in peeknpoke #9

merged 1 commit into from
Oct 9, 2024

Conversation

bhe4
Copy link

@bhe4 bhe4 commented Sep 23, 2024

add the close(fd) to fix the RESOURCE_LEAK issue

Tracked-On: OAM-124667

@sysopenci sysopenci added Valid commit message Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Sep 24, 2024
tanujtekriwal
tanujtekriwal suggested changes Sep 24, 2024
View reviewed changes
Copy link

@tanujtekriwal tanujtekriwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add "Tests Done: " in the commit message as part of commit message format.

mem_dump.c Show resolved Hide resolved
mem_dump.c Show resolved Hide resolved
@bhe4 bhe4 requested a review from tanujtekriwal September 25, 2024 01:51
@tanujtekriwal
Copy link

Also please add "Tests Done: " in the commit message as part of commit message format.

Please add this.

@bhe4 bhe4 force-pushed the fix_coverity_in_peeknpoke branch from c0ea6ba to 587f71a Compare September 25, 2024 05:29
@bhe4
Copy link
Author

bhe4 commented Sep 25, 2024

Added the Tests Done, Please help review.

@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

@sysopenci
Copy link

Dependent pr program name is not compatable this pr's program name, for more details please check tracked_on

@sysopenci
Copy link

Improper Commit Message
Improper Affects version

@bhe4 bhe4 mentioned this pull request Sep 25, 2024
Closed
@bhe4 bhe4 force-pushed the fix_coverity_in_peeknpoke branch from 587f71a to 2892013 Compare September 25, 2024 05:34
@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

tanujtekriwal
tanujtekriwal approved these changes Sep 25, 2024
View reviewed changes
Copy link

@tanujtekriwal tanujtekriwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Sep 25, 2024
@bhe4
coverity: fix the coverity issue in peeknpoke
91cb447 
1. add the close(fd) to fix the RESOURCE_LEAK issue
2. fix the insecure data handling in peeknpoke.c

Tests Done:
1. Build and boot
2. crashlog function works

Tracked-On: OAM-126085
Signed-off-by: Bo He <[email protected]>
@bhe4 bhe4 force-pushed the fix_coverity_in_peeknpoke branch from 2892013 to 91cb447 Compare October 8, 2024 05:06
tanujtekriwal
tanujtekriwal approved these changes Oct 8, 2024
View reviewed changes
Copy link

@tanujtekriwal tanujtekriwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Oct 8, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Oct 8, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 9231c49 into projectceladon:celadon/u/mr0/master Oct 9, 2024
17 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujtekriwal tanujtekriwal tanujtekriwal approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhe4 @tanujtekriwal @sysopenci