drm/virtio: Send flip event based on backend setting #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysopenci
added
Valid commit message
Pending Developer Approval
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
JeevakaPrabu,
kaushlen,
sgnanase,
shyjumon-n,
xyzhao2018,
xzhan34 and
yaoxinshi-intel
|
Improper Commit Message |
phreer
changed the title
feijiang1
reviewed
Dec 17, 2024
feijiang1
reviewed
Dec 17, 2024
feijiang1
reviewed
Dec 17, 2024
feijiang1
reviewed
Dec 17, 2024
| virtqueue_enable_cb(vgdev->vblank[output->index].vblank.vq); | ||
| do { | ||
| virtio_gpu_vblank_poll_arm(vgdev->vblank[output->index].vblank.vq); | ||
| } while (!virtqueue_enable_cb(vgdev->vblank[output->index].vblank.vq)); |
There was a problem hiding this comment.
In which case, virtqueue_enable_cb will return false and need run multiple times, then success?
There was a problem hiding this comment.
robust enhance to avoid dead loop.
There was a problem hiding this comment.
Should be safe enough to use like this. We can see the same usage in virtio-GPU.
feijiang1
reviewed
Dec 17, 2024
phreer
force-pushed
the
virtgpu-present-fence
branch
3 times, most recently
from
0dc1620 to
0390a3c
Compare
sysopenci
added
Invalid commit message
and removed
PR approved
Valid commit message
labels
|
Improper Commit Message |
Introduce per-CRTC flip counter that should be incremented when flip happens in back-end. Atomic commit worker should await change of the new flip sequence rather than vblank sequence. Present fences are also cached and signaled when flip happens. We introduce flip sequence feature for backward compatibility, meaning that we must wait for flip event only when we have flip sequence feature negotiated. This is to avoid breaks old hypervisor/device model. Tracked-On: OAM-128741 Signed-off-by: hangliu1 <[email protected]> Signed-off-by: Xue, Bosheng <[email protected]> Signed-off-by: Weifeng Liu <[email protected]>
phreer
force-pushed
the
virtgpu-present-fence
branch
from
78ae568 to
4f02e65
Compare
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
JeevakaPrabu,
kaushlen,
sgnanase,
shyjumon-n,
xyzhao2018,
xzhan34 and
yaoxinshi-intel
sysopenci
removed request for
dyang23,
feijiang1,
gkdeepa,
JeevakaPrabu,
kaushlen,
sgnanase,
shyjumon-n,
xyzhao2018 and
yaoxinshi-intel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache out fences in atomic commit and signal them when the backend asks to. The backend is supposed to send to frontend the number of fences to signal when the backend presents a frame to users. Only in this way we can preserve the semantics of present fence.
Tracked-On: OAM-128370