Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore extra cameras to ensure the multi preview #68

Conversation

jiaxuan-guo
Copy link

Issue Detailed: Fail to open 6 default virtio-camera with multi preview in aaag.

Issue Fixed: The multi camera app only supports up to 4 cameras. If the number of cameras exceeds 4, the extra cameras will be ignored and only the first four will be used.

Tests Done: Multi-camera preview works well after the change.

Tracked-On: OAM-128468

Copy link

@shivasku82 shivasku82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Dec 17, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

Issue Detailed: Fail to open 6 default virtio-camera with multi
preview in aaag.

Issue Fixed: The multi camera app only supports up to 4 cameras. If the number
of cameras exceeds 4, the extra cameras will be ignored and only the first four
will be used.

Tests Done: Multi-camera preview works well after the change.

Tracked-On: OAM-128468
Signed-off-by: Jade Guo <[email protected]>
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Failed and removed Engineering Build Not Started Engineering Build Not Started labels Dec 17, 2024
@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

Copy link

@shivasku82 shivasku82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 6e2735d into projectceladon:celadon/u/mr0/master Dec 17, 2024
21 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants