Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict tigera-operator secret access to namespace only, retain get/… #9570

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

vara2504
Copy link
Contributor

@vara2504 vara2504 commented Dec 6, 2024

…list/watch cluster-wide

tigera/operator#3630
https://tigera.atlassian.net/browse/EV-5410

vara@vara:~/bzprofiles/Clusters/tc_os$ ts
NAME        AVAILABLE   PROGRESSING   DEGRADED   SINCE
apiserver   True        False         False      115s
calico      True        False         False      90s
ippools     True        False         False      23m
vara@vara:~/bzprofiles/Clusters/tc_os$ k get rolebinding -A |grep tigera-operator-secrets
calico-apiserver   tigera-operator-secrets                             ClusterRole/tigera-operator-secrets                   6m19s
calico-system      tigera-operator-secrets                             ClusterRole/tigera-operator-secrets                   3m13s
tigera-operator    tigera-operator-secrets                             ClusterRole/tigera-operator-secrets                   24m

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@marvin-tigera marvin-tigera added this to the Calico v3.30.0 milestone Dec 6, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Dec 6, 2024
@vara2504 vara2504 marked this pull request as ready for review December 9, 2024 19:13
@vara2504 vara2504 requested a review from a team as a code owner December 9, 2024 19:13
Copy link
Contributor

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sridhartigera sridhartigera added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Dec 20, 2024
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Dec 20, 2024
@coutinhop
Copy link
Member

/sem-approve

@sridhartigera sridhartigera merged commit aa3fb74 into projectcalico:master Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants