[cherry pick] [v3.29] [release tool] Allow building and publishing image in hashrelease #9534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radTuti
added
docs-not-required
radTuti
force-pushed
the
cp-nightly-build
branch
from
717c93c to
a913f19
Compare
…ashrelease (projectcalico#9429) * update cleaning old hashreleases * Allow building and publishing images in hashrelease * fix building images for hashrelease - key-cert-provisioner: add release-build and release-publish targets - add ability to skip release notes * address review feedback * fix publishing images for hashrelease - add custom registry to pinnedversion - allowing skipping validation for publish - fail if hashrelease latest is set while using custom registry - move hashrelease validation to calico manager - update .gitignore to ignore publishing identifier files - fix key-cert-provisioner publishing * update publish prereqs - check hashrelease server config if publishHashrelease == true - move release-verify from Makefile to golang tool * merge format fix * utilize operator optimization * remove Registry in pinnedversion * release notes uses projectcalico org * update hashrelease pipeline * address review comments
…#9554) * Check code generation as part of release / hashrelease * Add better error mesg
radTuti
force-pushed
the
cp-nightly-build
branch
from
04d89ff to
2f7f878
Compare
radTuti
changed the title
coutinhop
reviewed
Dec 5, 2024
…ectcalico#9558)" This reverts commit e9a1058.
this does not play well with building windows
coutinhop
reviewed
Dec 6, 2024
Makefile
Outdated
Comment on lines
72
to
73
| cd ./manifests/ocp/ && \ | ||
| for file in operator.tigera.io_*.yaml; do echo "downloading $$file from operator repo" && curl -fsSL https://raw.githubusercontent.com/tigera/operator/$(OPERATOR_BRANCH)/pkg/crds/operator/$${file%_crd.yaml}.yaml -o $${file}; done |
There was a problem hiding this comment.
we don't need this anymore since the operator will bootstrap the CRDs for OpenShift (#9547)
coutinhop
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This take in commits from master to allow this
OPERATOR_BRANCHfrom hashrelease semaphore file w/ update for the correct operator branch for this branchRelated issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.