EXTRA DiagramConverter.ts prevent extra init and mark member as readonly

process-analytics · Dec 11, 2024 · 4f51a03 · 4f51a03
1 parent 915a8d9
commit 4f51a03
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/component/parser/json/converter/DiagramConverter.ts b/src/component/parser/json/converter/DiagramConverter.ts
@@ -40,7 +40,7 @@ export default class DiagramConverter {
     private readonly parsingMessageCollector: ParsingMessageCollector,
   ) {}
 
-  private convertedFonts = new Map<string, Font>();
+  private readonly convertedFonts = new Map<string, Font>();
 
   deserialize(bpmnDiagrams: BPMNDiagram[] | BPMNDiagram): BpmnModel {
     const flowNodes: Shape[] = [];
@@ -66,8 +66,6 @@ export default class DiagramConverter {
   }
 
   private deserializeFonts(bpmnLabelStyle: BPMNLabelStyle[] | BPMNLabelStyle): void {
-    this.convertedFonts = new Map();
-
     for (const labelStyle of ensureIsArray(bpmnLabelStyle))
       for (const font of ensureIsArray(labelStyle.Font))
         this.convertedFonts.set(labelStyle.id, new Font(font.name, font.size, font.isBold, font.isItalic, font.isUnderline, font.isStrikeThrough));