chore(deps-dev): bump the lint group with 5 updates (#3215)

The eslint configuration has been adapted and the code adjusted to match the new eslint rules.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bouffard <[email protected]>

.eslintrc.cjs

@@ -61,6 +61,7 @@ module.exports = {
     'unicorn/no-new-array': 'off', // In contradiction with unicorn/new-for-builtins: Use `new Array()` instead of `Array()`
     'unicorn/no-null': 'off', // We don't know the impact on mxGraph code
     'unicorn/no-useless-undefined': 'off', // The "undefined" value is useful where we use it and change some mxGraph code
+    'unicorn/prefer-global-this': 'off', // We only target the browser, so it is valid to use the window object. In addition, using 'globalThis' require additional changes in the code/configuration to work.
   },
   overrides: [
     // typescript
@@ -117,6 +118,16 @@ module.exports = {
 
         '@typescript-eslint/restrict-plus-operands': 'error',
 
+        // disable the base rule as it can report incorrect errors when using '@typescript-eslint/no-unused-expressions', see https://typescript-eslint.io/rules/no-unused-expressions/#how-to-use
+        'eslint/no-unused-expressions': 'off',
+        '@typescript-eslint/no-unused-expressions': [
+          'error',
+          {
+            allowShortCircuit: true,
+            allowTernary: true,
+          },
+        ],
+
         // The following lines are commented, because they show errors on files other than the demo:
         // '@typescript-eslint/no-base-to-string': 'error',
         // '@typescript-eslint/no-unsafe-assignment': 'error',

package.json

@@ -119,8 +119,8 @@
     "@types/debug": "~4.1.12",
     "@types/jest-image-snapshot": "~6.4.0",
     "@types/minimist": "~1.2.5",
-    "@typescript-eslint/eslint-plugin": "~7.18.0",
-    "@typescript-eslint/parser": "~7.18.0",
+    "@typescript-eslint/eslint-plugin": "~8.14.0",
+    "@typescript-eslint/parser": "~8.14.0",
     "autoprefixer": "~10.4.20",
     "clipboardy": "~4.0.0",
     "cross-env": "~7.0.3",
@@ -130,12 +130,12 @@
     "eslint-config-prettier": "~9.1.0",
     "eslint-import-resolver-typescript": "~3.6.3",
     "eslint-plugin-import": "~2.31.0",
-    "eslint-plugin-jest": "~28.8.3",
+    "eslint-plugin-jest": "~28.9.0",
     "eslint-plugin-jest-extended": "^2.4.0",
     "eslint-plugin-notice": "~1.0.0",
-    "eslint-plugin-playwright": "~1.7.0",
+    "eslint-plugin-playwright": "~2.0.1",
     "eslint-plugin-prettier": "~5.2.1",
-    "eslint-plugin-unicorn": "~55.0.0",
+    "eslint-plugin-unicorn": "~56.0.0",
     "expect-playwright": "~0.8.0",
     "fs-extra": "~11.2.0",
     "husky": "~9.1.6",

src/component/mxgraph/shape/render/index.ts

@@ -15,6 +15,6 @@ limitations under the License.
 */
 
 // export types first, otherwise typedoc doesn't generate the subsequent doc correctly (no category and uses the file header instead of the actual TSDoc)
-export * from './render-types';
+export type * from './render-types';
 export { BpmnCanvas, type BpmnCanvasConfiguration } from './BpmnCanvas';
 export { IconPainter, IconPainterProvider, type PaintParameter } from './icon-painter';

src/component/registry/index.ts

@@ -15,5 +15,5 @@ limitations under the License.
 */
 
 // export types first, otherwise typedoc doesn't generate the subsequent doc correctly (no category and uses the file header instead of the actual TSDoc)
-export * from './types';
+export type * from './types';
 export { BpmnElementsRegistry } from './bpmn-elements-registry';

src/model/bpmn/json/Semantic.ts

@@ -28,15 +28,12 @@ export interface TExtension {
 }
 
 // <xsd:any namespace="##other" processContents="lax" minOccurs="0" maxOccurs="unbounded" />
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
-export interface TExtensionElements {}
+export type TExtensionElements = object;
 
 // mixed="true"
 // <xsd:any namespace="##any" processContents="lax" minOccurs="0"/>
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
-export interface TScript {}
+export type TScript = object;
 
 // mixed="true"
 // <xsd:any namespace="##any" processContents="lax" minOccurs="0"/>
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
-export interface TText {}
+export type TText = object;

test/bundles/.eslintrc.cjs

@@ -15,5 +15,9 @@ limitations under the License.
 */
 
 module.exports = {
-  extends: ['plugin:playwright/jest-playwright'],
+  extends: ['plugin:playwright/recommended'],
+  rules: {
+    /* This rule is for playwright-test and we are using jest-playwright */
+    'playwright/no-standalone-expect': 'off',
+  },
 };

test/config/jest.retries.ts

@@ -15,7 +15,8 @@ limitations under the License.
 */
 
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore js file with commonjs export
+// @ts-ignore use a shared js file with commonjs export
+// eslint-disable-next-line @typescript-eslint/no-require-imports -- use a shared js file with commonjs export
 import environmentUtils = require('@test/shared/environment-utils.cjs');
 
 const onCi = environmentUtils.isRunningOnCi();

test/e2e/.eslintrc.cjs

@@ -15,5 +15,9 @@ limitations under the License.
 */
 
 module.exports = {
-  extends: ['plugin:playwright/jest-playwright'],
+  extends: ['plugin:playwright/recommended'],
+  rules: {
+    /* This rule is for playwright-test and we are using jest-playwright */
+    'playwright/no-standalone-expect': 'off',
+  },
 };

test/performance/.eslintrc.cjs

@@ -15,5 +15,9 @@ limitations under the License.
 */
 
 module.exports = {
-  extends: ['plugin:playwright/jest-playwright'],
+  extends: ['plugin:playwright/recommended'],
+  rules: {
+    /* This rule is for playwright-test and we are using jest-playwright */
+    'playwright/no-standalone-expect': 'off',
+  },
 };

test/shared/visu/bpmn-page-utils.ts

@@ -26,7 +26,8 @@ import type { ElementHandle, Page } from 'playwright';
 import debugLogger from 'debug';
 
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore js file with commonjs export
+// @ts-ignore use a shared js file with commonjs export
+// eslint-disable-next-line @typescript-eslint/no-require-imports -- use a shared js file with commonjs export
 import environmentUtils = require('../environment-utils.cjs');
 
 import { delay } from './test-utils';