Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ISbmClient for easier testing when used in other projects, adde… #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ianbeemsterboerr
Copy link

…d a new constructor to allow injecting of HttpClient.

…d a new constructor to allow injecting of HttpClient.
@AntonioKoB
Copy link

Can this be fixed and approved @prjseal ?

@michaellegner
Copy link

michaellegner commented Mar 5, 2022

I gave up on this package and made my own nuget package to call their current API. It's not hard at all. I am using Refit.

@AntonioKoB
Copy link

@michaellegner I also love refit. and that's something @prjseal could invest on this repository. But unlike you, I don't give up on this repo. I know @prjseal 's competences and I follow him on Youtube. I am sure he will improve this repo. I can help if needed.

@prjseal
Copy link
Owner

prjseal commented Mar 5, 2022

Hi all. Sorry for not replying on here for a while. The repo isn't dead. I appreciate your comments, issues and PRs. I've recently changed jobs at work and it frees me up for more open source work. I will catch up on here and reply properly soon.

@michaellegner
Copy link

@michaellegner I also love refit. and that's something @prjseal could invest on this repository. But unlike you, I don't give up on this repo. I know @prjseal 's competences and I follow him on Youtube. I am sure he will improve this repo. I can help if needed.

Yes but from what I remember this repo doesn't call the right API at Slack anyway.

@michaellegner
Copy link

I am using blocks (https://api.slack.com/block-kit) and a select number of methods in this API: https://api.slack.com/methods

Thought maybe this makes the tests work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants