Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "share" footer section #2300

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add "share" footer section #2300

merged 1 commit into from
Oct 24, 2023

Conversation

jonaharagon
Copy link
Member

Changes proposed in this PR:

  • Add sharing section to footer:

DVlQ7pxnyQB3Tuth

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

jonaharagon added a commit that referenced this pull request Oct 10, 2023
@jonaharagon
Add "share" section (#2300)
9f0fd97
@jonaharagon jonaharagon force-pushed the jonaharagon/social-sharing branch from 206c11d to 9f0fd97 Compare October 10, 2023 02:41
@netlify

This comment was marked as outdated.

Sign in to view
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65376d77c2df7b283347fc33
😎 Deploy Preview https://deploy-preview-2300.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jonaharagon added a commit that referenced this pull request Oct 10, 2023
@jonaharagon
Add "share" section (#2300)
a08e2d5
@jonaharagon jonaharagon force-pushed the jonaharagon/social-sharing branch from 9f0fd97 to a08e2d5 Compare October 10, 2023 02:51
jonaharagon added a commit that referenced this pull request Oct 10, 2023
@jonaharagon
Add "share" section (#2300)
69fe18b
@jonaharagon jonaharagon force-pushed the jonaharagon/social-sharing branch from a08e2d5 to 69fe18b Compare October 10, 2023 02:58
jonaharagon added a commit that referenced this pull request Oct 10, 2023
@jonaharagon
Add "share" section (#2300)
0703c5e
@jonaharagon jonaharagon force-pushed the jonaharagon/social-sharing branch from 69fe18b to 0703c5e Compare October 10, 2023 03:07
jonaharagon added a commit that referenced this pull request Oct 10, 2023
@jonaharagon
Add "share" section (#2300)
e7a787f
@jonaharagon jonaharagon force-pushed the jonaharagon/social-sharing branch from 0703c5e to e7a787f Compare October 10, 2023 03:16
@freddy-m freddy-m self-requested a review October 10, 2023 12:22
freddy-m
freddy-m reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As cool as this is, it just seems like extra clutter on the page. I personally don't know whether its needed, but would be interested in the thoughts of @privacyguides/team

@jonaharagon jonaharagon added this to the v3.17 milestone Oct 14, 2023
@jonaharagon @dngray
Add "share" section (#2300)
301e1b2 
Signed-off-by: Daniel Gray <[email protected]>
Signed-off-by: blacklight447 <[email protected]>
@dngray dngray force-pushed the jonaharagon/social-sharing branch from e7a787f to 301e1b2 Compare October 24, 2023 06:48
@dngray dngray merged commit 301e1b2 into main Oct 24, 2023
3 of 6 checks passed
@dngray dngray deleted the jonaharagon/social-sharing branch October 24, 2023 06:48
@dngray dngray added the fix:seo search engine optimization! label Oct 24, 2023
dngray pushed a commit that referenced this pull request Oct 24, 2023
@jonaharagon @dngray
Add "share" section (#2300)
43b346a 
Signed-off-by: Daniel Gray <[email protected]>
Signed-off-by: blacklight447 <[email protected]>
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-17/15136/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddy-m freddy-m freddy-m left review comments

@blacklight447 blacklight447 blacklight447 approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
fix:seo search engine optimization!
Projects
None yet
Milestone
v3.17
Development

Successfully merging this pull request may close these issues.
5 participants
@jonaharagon @privacyguides-bot @freddy-m @dngray @blacklight447