New package for general-purpose zero-knowledge circuits #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedoor
force-pushed
the
feat/circuits
branch
from
1140533 to
3f1ccad
Compare
cedoor
changed the title
0xjei
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Partial-review: great configs but the npm scripts are not working right now (both circom 2.1.5 and 2.1.6). Left some nits and comments but great work so far 👍
yarn circom:compile poseidon-proof
===| Compiling the circuit |===
Error: Compiler error:
Error: Command failed: circom --sym --wasm --r1cs -p bn128 -o ./build/poseidon-proof -l ../../node_modules/circomlib/circuits --verbose --inspect --O1 ./circuits/main/poseidon-proof.circom
error[P1014]: The file ../poseidon-proof.circom to be included has not been found
= Consider using compilation option -l to indicate include paths
It's a |
0xjei
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new package for providing general-purpose zero-knowledge circuits has been added. As other projects/protocols become modularized, reusable circuits could be managed in this package, tested, and documented.
@zk-kit/circuitscan be installed with NPM (or Yarn) and its circuits accessed fromnode_modules/@zk-kit/circuits.Related Issue
Closes #73
Does this introduce a breaking change?