Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused return value from _check() method #24

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

0xjei
Copy link
Member

@0xjei 0xjei commented Jul 3, 2024

Description

This PR removes the unused return value from _check() method from Excubia abstract contract. See this comment for more.

Related Issue(s)

none

Other information

none

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn compile without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@0xjei 0xjei requested a review from cedoor July 3, 2024 13:21
@0xjei 0xjei requested a review from sripwoud as a code owner July 3, 2024 13:21
@0xjei 0xjei force-pushed the refactor/check branch from 9c9b4bb to 592e767 Compare July 3, 2024 14:46
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment (not related to your code).

Looks like there's been an error while compiling contracts.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@0xjei 0xjei force-pushed the feat/porting-maci-gatekeepers branch from fb7a867 to 98badde Compare July 3, 2024 15:09
@0xjei 0xjei force-pushed the refactor/check branch from 68d2b55 to a2eadef Compare July 3, 2024 15:15
@0xjei 0xjei changed the base branch from feat/porting-maci-gatekeepers to main July 3, 2024 15:19
@0xjei 0xjei force-pushed the refactor/check branch from a2eadef to f4e023f Compare July 3, 2024 15:22
@0xjei 0xjei merged commit 2641e84 into main Jul 3, 2024
16 checks passed
@0xjei 0xjei deleted the refactor/check branch July 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants