Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve the ballot submission process #532

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: improve the ballot submission process #532

merged 1 commit into from
Dec 11, 2024

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Dec 6, 2024 •
edited
Loading

Description

  • remove the popup dialog before submit ballot
  • add error message in the toast error when onVote
  • add check my ballot button on the BallotOverview widget
  • adjust the styling of the BallotOverview widget

Related Issues
close #520

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:16am

@crisgarner
Copy link
Contributor

Thanks! just one comment while testing

@kittybest kittybest self-assigned this Dec 9, 2024
@kittybest kittybest force-pushed the chore/ballot-submission branch from 78744d1 to aade130 Compare December 9, 2024 16:36
@kittybest kittybest force-pushed the chore/ballot-submission branch from aade130 to 5d28da3 Compare December 9, 2024 16:59
@kittybest kittybest force-pushed the chore/ballot-submission branch from 5d28da3 to 0a5d785 Compare December 9, 2024 17:09
@crisgarner
Copy link
Contributor

Thanks! With the new version, I noticed that the transaction gets stuck in the UI
image

Even after the tx is confirmed
image

@kittybest kittybest force-pushed the chore/ballot-submission branch from 0a5d785 to ffdbf91 Compare December 11, 2024 07:49
@kittybest kittybest added bug Something isn't working chore Chore tasks and removed bug Something isn't working labels Dec 11, 2024
@ctrlc03 ctrlc03 force-pushed the chore/ballot-submission branch from ffdbf91 to 4a8e00a Compare December 11, 2024 10:07
@crisgarner
Copy link
Contributor

Thanks!

@crisgarner crisgarner merged commit ccaa683 into main Dec 11, 2024
17 checks passed
@crisgarner crisgarner deleted the chore/ballot-submission branch December 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisgarner crisgarner crisgarner approved these changes

@ctrlc03 ctrlc03 Awaiting requested review from ctrlc03 ctrlc03 is a code owner

@0xmad 0xmad Awaiting requested review from 0xmad 0xmad is a code owner

Assignees

@kittybest kittybest

Labels
chore Chore tasks
Projects
MACI Platform
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX: remove submit ballot popup
2 participants
@kittybest @crisgarner