main: fix list assembly of suppress #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angeloc FYI - I made some more fixes to this functionality and added a test |
angeloc
reviewed
Oct 12, 2023
|
Nice! Thank you, I was looking to adding the test but a bit short on time. |
when passing `--suppress=a --suppress=b` into the argparse instance, we would have gotten weird results. Fix that and also fully support having multiple suppression as a space separated list passed to the parser. To avoid future regressions a test was added. Co-authored-by: Angelo Compagnucci [email protected] Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann
force-pushed
the
fix/suppress-handling
branch
from
8a3a0f1 to
c8d5ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when passing
--suppress=a --suppress=bintothe argparse instance, we would have gotten
weird results.
Fix that and also fully support having multiple
suppression as a space separated list passed
to the parser.
To avoid future regressions a test was added.
Co-authored-by: Angelo Compagnucci [email protected]
Pull request checklist
Bugfix
New feature