Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field unit tests #360

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Field unit tests #360

merged 3 commits into from
Dec 19, 2024

Conversation

landinjm
Copy link
Contributor

Description

Redid fields.h with some more defensive programming. Also added a unit test and updated the CI to run the unit tests.

Checklist

Miscellaneous items that may need to be done when making a PR:

  • Documentation related to this PR is up to date (Doxygen format)
  • Unit test(s)
  • Code is properly formatted
  • Application update script is up to date
  • PR labels are applied
  • Issues are linked

@landinjm landinjm requested a review from fractalsbyx December 17, 2024 11:53
@landinjm landinjm changed the title Field_unit_tests Field unit tests Dec 19, 2024
fractalsbyx
fractalsbyx approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@fractalsbyx fractalsbyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@landinjm landinjm merged commit 0b76ee7 into prisms-center:devel Dec 19, 2024
5 of 8 checks passed
@landinjm landinjm deleted the field_unit_tests branch December 19, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalsbyx fractalsbyx fractalsbyx approved these changes

Assignees
No one assigned
Labels
Status: Needs review Type: Error handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@landinjm @fractalsbyx