Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audible speed advisories #628

Merged
merged 48 commits into from
Sep 19, 2024
Merged

Add audible speed advisories #628

merged 48 commits into from
Sep 19, 2024

Conversation

adeveloper-wq
Copy link
Member

@adeveloper-wq adeveloper-wq commented Jun 27, 2024 •
edited by PaulPickhardt
Loading

If available, link to the ticket

Closes: #625

QA Checklist

Author

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

Reviewer

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

@PaulPickhardt PaulPickhardt changed the title Refactor audio instructions code Refactor and optimize audio instructions code Jun 28, 2024
@adeveloper-wq
Copy link
Member Author

TODO: Remove navigation instructions code. Only keep speed advisory stuff. (#656 & #625)

@adeveloper-wq adeveloper-wq changed the title Refactor and optimize audio instructions code Add audible speed advisories Jul 22, 2024
@PaulPickhardt
Merge dev
c50715e
@PaulPickhardt
Add setting for using audio routing instructions seperately
004bb6b
@PaulPickhardt
Start fixing the wait for green audio information
ca36659
@PaulPickhardt
Merge branch 'dev' into refactor-audio-instructions-code
e934ec5
@PaulPickhardt
Fix play audio when waiting for green
18f43d8
@PaulPickhardt
First speed advisory instructions only implementation
80a49ab
@PaulPickhardt
Fix audio instruction min distance
56c0751
@PaulPickhardt
Place audio speed advisory option in main settings
2e9c0af
@PaulPickhardt
Fix calc second next phase
16bb00a
@PaulPickhardt
Enhance audio speed advisory instruction generation and start adding …
b1fe390 
…test cases to validate this functionality
@PaulPickhardt
Add test data for audio text generation
d369e7a
@PaulPickhardt
Add new text generation algo with test cases
d6e75bc
@PaulPickhardt
Merge branch 'dev' into refactor-audio-instructions-code
2ccab18
@PaulPickhardt
Round distance to sg up to 25m accuracy
22138df
@PaulPickhardt
Add audio service to enable hearing music and speed advisory instruct…
add2c56 
…ions
@PaulPickhardt
Fix speech rate
bfffb06
@PaulPickhardt
Add prediction not valid anymore and adjust speechrate values
2d4085c
@PaulPickhardt PaulPickhardt marked this pull request as ready for review August 29, 2024 12:30
@PaulPickhardt PaulPickhardt self-assigned this Aug 29, 2024
@adeveloper-wq
Copy link
Member Author

Lets add an array to the track object with information about whether the audio feature was enabled. Eg audioFeatureEnabled: [{1725543673: true}, {1725543683: false}]

@adeveloper-wq
Copy link
Member Author

Apart from some documentation ambiguities and some minor refactoring suggestions everythings looks good and works well! Let me know if you want to talk about some comments. @PaulPickhardt

@PaulPickhardt PaulPickhardt merged commit 83f0041 into dev Sep 19, 2024
1 check passed
@PaulPickhardt PaulPickhardt deleted the refactor-audio-instructions-code branch September 19, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulPickhardt PaulPickhardt PaulPickhardt approved these changes

Assignees

@PaulPickhardt PaulPickhardt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audible navigation instructions
2 participants
@adeveloper-wq @PaulPickhardt