Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for 0.16 #14

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

ixfd64
Copy link
Contributor

@ixfd64 ixfd64 commented Dec 1, 2024

  • this is mostly a documentation update
    • added a section on AutoPrimeNet
    • changed the deprecated results.text to results.json.txt
    • updated macOS info
  • updated the INI file to include default values for the new 0.16 options
  • added a filter so that GitHub Actions workflows only run when code is changed

README.txt Outdated
@@ -71,8 +69,7 @@ General requirements:
- an OpenCL SDK

Please note: the AMD APP SDK has been discontinued. If you still want to use it
to compile mfakto, make sure you have version 2.5 or later. You can download
the SDK here: https://community.amd.com/thread/227948
to compile mfakto, make sure you have version 2.5 or later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider removing this whole paragraph. Just because mfakto can be compiled with software discontinued 9 years ago, should an ordinary user care? If this library still needs to be mentioned, I would do it closer to the end of this document, not in the beginning. Otherwise it sounds like mfakto has some obsolete dependency, which makes mfakto somewhat obsolete too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree there is no need to keep this section anymore. It seems out of place now.

@@ -71,8 +69,7 @@ General requirements:
- an OpenCL SDK

Please note: the AMD APP SDK has been discontinued. If you still want to use it
to compile mfakto, make sure you have version 2.5 or later. You can download
the SDK here: https://community.amd.com/thread/227948
to compile mfakto, make sure you have version 2.5 or later.

#############
# 1.1 Linux #
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux part needs rewriting, as ROCm is not a requirement. I can compile and run mfakto without ROCm. With VectorSize=1 fixed, mfakto becomes usable on Intel GPUs. I'd rather see potential users try mfakto on whatever GPU they have.

Copy link
Contributor Author

@ixfd64 ixfd64 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see, there is an AMD_APP_DIR variable in the makefile that points to an ROCm installation:

AMD_APP_DIR = /opt/rocm/opencl

It has been there for as long as I can remember. Did you remove this variable before compiling mfakto?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't need to change or override anything in the Makefile. I just need to install OpenCL headers from the distro.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems AMD_APP_DIR isn't even needed anymore as I was able to compile mfakto in WSL after removing this variable from the makefile. I'll create a separate PR as this one is mainly for documentation changes.

README.txt Outdated
interim, resulting in duplicate work and wasted cycles.
partial results as PrimeNet may reassign the exponent to someone else in
the meantime; this can lead to duplicate work and wasted cycles. You can
easily avoid this by setting Stages=0 in the INI file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good recommendation, considering that Stages=0 is not the default. Maybe the user should be asked to wait until all stages complete for the exponent.

Copy link
Contributor Author

@ixfd64 ixfd64 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brubsby did recently change the default to Stages=0 for mfaktc: primesearch/mfaktc@5757f54

I don't know if he intends to do the same for mfakto, although I do agree this part is unnecessary either way.

README.txt Outdated
a program called AutoPrimeNet that does so. See the AutoPrimeNet download
page for instructions: https://download.mersenne.ca/AutoPrimeNet

Another option is to manually submit the results:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used AutoPrimeNet yet, but my assumption is that is gets assignments too. Then it should be described earlier.

I would group getting assignments and submitting results for every workflow, like:

AutoPrimeNet:

  • how to get assigments
  • how to submit results

mersenne.ca

  • how to get assigments
  • how to submit results

and so on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea.

@jcoxdco
Copy link

jcoxdco commented Dec 7, 2024

Great to see the readme get some love. Something I noticed recently is the VC++ Redistributable version 10 is no longer supported. (11 and 12 are not either.) Readme.txt line 273ish.

Per Microsoft:

Visual Studio versions since Visual Studio 2015 share the same Redistributable files. For example, any apps built by the Visual Studio 2015, 2017, 2019, or 2022 toolsets can use the latest Microsoft Visual C++ Redistributable.

The link to the latest supported versions is: https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170

@ixfd64
Copy link
Contributor Author

ixfd64 commented Dec 8, 2024

@jcoxdco Looks like the links now lead to 404 errors. I'll update the readme to point to the new download page.

@henning-gerhardt
Copy link
Contributor

A note from https://www.mersenneforum.org/node/11037/page79#post1062989:

mfakto 0.16beta.2 mfakto.ini still has
Version 0.15
in its header comment.

Maybe this could be adjusted in this pull request, too?

@ixfd64
Copy link
Contributor Author

ixfd64 commented Dec 8, 2024

@henning-gerhardt I bumped the version in my latest change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants