Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SystemArgumentInsteadOfClass linter and fix bug with whitespace in rendered class #3220

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 5, 2024

What are you trying to accomplish?

Follow up to #3219 I found a couple of integration problems:

  1. There was still a linter in place that would tell folks to use SystemArgumentInsteadOfClass This PR removes that.
  2. There was a bug where if a BaseComponent doesn't have any other classes passed in, when the system argument is converted it has a leading whitespace.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 53313c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan marked this pull request as ready for review December 5, 2024 18:29
@jonrohan jonrohan requested a review from a team as a code owner December 5, 2024 18:29
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 🎉

@jonrohan jonrohan merged commit 688a4a2 into main Dec 5, 2024
35 checks passed
@jonrohan jonrohan deleted the remove_system_argument_instead_of_class_linter branch December 5, 2024 18:37
@primer primer bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants