Skip to content

Commit

Permalink
Fix issue causing AutoComplete elements to overflow their container
Browse files Browse the repository at this point in the history
  • Loading branch information
camertron committed Dec 3, 2024
1 parent a574b0e commit 620e86b
Show file tree
Hide file tree
Showing 3 changed files with 127 additions and 0 deletions.
1 change: 1 addition & 0 deletions app/components/primer/beta/auto_complete.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class AutoComplete < Primer::Component
system_arguments[:"allow-out-of-bounds"] = ""
system_arguments[:id] = @list_id
system_arguments[:popover] = ""
system_arguments[:overflow_y] = :auto
system_arguments[:classes] = class_names(
"ActionListWrap ActionListWrap--inset",
@overlay_classes,
Expand Down
63 changes: 63 additions & 0 deletions lib/primer/classify/utilities.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1877,3 +1877,66 @@
- flex-md-shrink-0
- flex-lg-shrink-0
- flex-xl-shrink-0
:overflow:
:auto:
- .overflow-auto
- .overflow-sm-auto
- .overflow-lg-auto
- .overflow-xl-auto
:hidden:
- .overflow-hidden
- .overflow-sm-hidden
- .overflow-lg-hidden
- .overflow-xl-hidden
:scroll:
- .overflow-scroll
- .overflow-sm-scroll
- .overflow-lg-scroll
- .overflow-xl-scroll
:visible:
- .overflow-visible
- .overflow-sm-visible
- .overflow-lg-visible
- .overflow-xl-visible
:overflow_x:
:auto:
- .overflow-x-auto
- .overflow-sm-x-auto
- .overflow-lg-x-auto
- .overflow-xl-x-auto
:hidden:
- .overflow-x-hidden
- .overflow-sm-x-hidden
- .overflow-lg-x-hidden
- .overflow-xl-x-hidden
:scroll:
- .overflow-x-scroll
- .overflow-sm-x-scroll
- .overflow-lg-x-scroll
- .overflow-xl-x-scroll
:visible:
- .overflow-x-visible
- .overflow-sm-x-visible
- .overflow-lg-x-visible
- .overflow-xl-x-visible
:overflow_y:
:auto:
- .overflow-y-auto
- .overflow-sm-y-auto
- .overflow-lg-y-auto
- .overflow-xl-y-auto
:hidden:
- .overflow-y-hidden
- .overflow-sm-y-hidden
- .overflow-lg-y-hidden
- .overflow-xl-y-hidden
:scroll:
- .overflow-y-scroll
- .overflow-sm-y-scroll
- .overflow-lg-y-scroll
- .overflow-xl-y-scroll
:visible:
- .overflow-y-visible
- .overflow-sm-y-visible
- .overflow-lg-y-visible
- .overflow-xl-y-visible
63 changes: 63 additions & 0 deletions lib/tasks/custom_utilities.yml
Original file line number Diff line number Diff line change
Expand Up @@ -370,3 +370,66 @@
- flex-md-shrink-0
- flex-lg-shrink-0
- flex-xl-shrink-0
:overflow:
:auto:
- .overflow-auto
- .overflow-sm-auto
- .overflow-lg-auto
- .overflow-xl-auto
:hidden:
- .overflow-hidden
- .overflow-sm-hidden
- .overflow-lg-hidden
- .overflow-xl-hidden
:scroll:
- .overflow-scroll
- .overflow-sm-scroll
- .overflow-lg-scroll
- .overflow-xl-scroll
:visible:
- .overflow-visible
- .overflow-sm-visible
- .overflow-lg-visible
- .overflow-xl-visible
:overflow_x:
:auto:
- .overflow-x-auto
- .overflow-sm-x-auto
- .overflow-lg-x-auto
- .overflow-xl-x-auto
:hidden:
- .overflow-x-hidden
- .overflow-sm-x-hidden
- .overflow-lg-x-hidden
- .overflow-xl-x-hidden
:scroll:
- .overflow-x-scroll
- .overflow-sm-x-scroll
- .overflow-lg-x-scroll
- .overflow-xl-x-scroll
:visible:
- .overflow-x-visible
- .overflow-sm-x-visible
- .overflow-lg-x-visible
- .overflow-xl-x-visible
:overflow_y:
:auto:
- .overflow-y-auto
- .overflow-sm-y-auto
- .overflow-lg-y-auto
- .overflow-xl-y-auto
:hidden:
- .overflow-y-hidden
- .overflow-sm-y-hidden
- .overflow-lg-y-hidden
- .overflow-xl-y-hidden
:scroll:
- .overflow-y-scroll
- .overflow-sm-y-scroll
- .overflow-lg-y-scroll
- .overflow-xl-y-scroll
:visible:
- .overflow-y-visible
- .overflow-sm-y-visible
- .overflow-lg-y-visible
- .overflow-xl-y-visible

0 comments on commit 620e86b

Please sign in to comment.