-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Autocomplete): Convert to CSS modules behind feature flag #5453
Conversation
…-tests/autocomplete
….com/primer/react into francinelucca/e2e-tests/autocomplete
🦋 Changeset detectedLatest commit: 5be57e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
…ucca/e2e-tests/autocomplete
size-limit report 📦
|
….com/primer/react into hussam-i-am/css-modules-autocomplete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that was easy! 😂
Not sure if we should tackle these Box styles too, or do that later (maybe if we have a chunk of word dedicated to removing Box) https://github.com/primer/react/pull/5451/files#diff-9dcb6a16b513af6dc1d448d292d3bddc55c5ac493994342a07aca673980adce6 |
Closes https://github.com/github/primer/issues/4303
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist